Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

save the model in a sensible place #227

Merged
merged 1 commit into from
Nov 26, 2024
Merged

save the model in a sensible place #227

merged 1 commit into from
Nov 26, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Nov 26, 2024 •
edited
Loading

Pull Request

Description

  • save model in model sensible place
  • fix timestamp in tests

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

zakwatts
zakwatts approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@zakwatts zakwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@peterdudfield peterdudfield merged commit be90200 into main Nov 26, 2024
3 checks passed
@peterdudfield peterdudfield deleted the issue/fix-tests branch November 26, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakwatts zakwatts zakwatts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @zakwatts